3. [Repositories] Creating a Project Output9. Approving Your Pull Request
Feedback

9 - Approving your Pull Request

This content is also available at learn.palantir.com ↗ and is presented here for accessibility purposes.

📖 Task Introduction

Explore the PR approval helper options and complete the merge.

🔨 Task Instructions

The previous task sends you immediately to the PR approval page, but you can also see all open and closed PRs in the repository by clicking the Pull request menu option across the top of your repository screen (it may be hidden in the More ▾ dropdown menu).

  1. Click through each of the PR helper tabs, noting, for instance:

    • Overview: CI checks have recently passed
    • Files changed: Among the files changed is the “shrinkwrap” file discussed briefly in the previous tutorial (details below).
    • Pipeline Review: A visual representation of the combination of the three inputs into the clean output.
    • Commits: Which specific commits were made on the feature branch that we’ll be merging into Master.
    • Conversation: An interface for providing comments between project members, including between PR submitter and approver if changes are needed.

    ℹ️ Each repository contains a “shrinkwrap” file which defines the mapping between each path referenced in the repository, the unique ID (RID) for that dataset referenced by that path, and the current path for that dataset. This is helpful when a dataset is moved between folders, for instance. You may encounter shrinkwrap errors for a few reasons, such as dataset deletions, renaming, or relocation.

  2. Click Squash and merge in the bottom right, and confirm the option in the pop-up window.

  3. Once the purple Merged indicator appears in the top right, it is safe to click the X Delete branch button in the bottom right.

  4. Return to the Code tab of your repository and build flight_alerts_clean.py on the new, merged Master branch.

  5. Once the build completes, verify the output in the dataset application.