2. [Repositories] Introduction to Data Transformations11. Approving A Pr And Merging Into Master
Feedback

11 - Approving a PR and Merging into Master

This content is also available at learn.palantir.com ↗ and is presented here for accessibility purposes.

📖 Task Introduction

This simple codebase doesn’t require much of a review, but the Code Repositories application comes equipped with a set of features to validate code changes and their downstream impact in your data pipeline. In this task, you’ll approve the PR you just generated.

🔨 Task Instructions

  1. Select the Pull Requests menu item along the top of your application screen to bring up a listing of all open PRs in the repository (depending on your browser zoom level, the Pull Requests item may be contained in the More ▾ dropdown menu).
  2. Select your PR from the list (it should be the only one).
  3. Review some available tabs, including Pipeline review, which provides a visual of the relationships between relevant input and output datasets, and the Commits tab where you can drill into each commit associated with the PR. These tabs will be increasingly useful for understanding the impact of code changes on the entire pipeline as we add complexity throughout this training track.
  4. Let’s assume you have adequately reviewed this PR and are ready to approve it. In the bottom right corner of the UI, choose the Squash and merge option. Then confirm your selection in the pop-up window by selecting Squash & Merge.
  5. You may now safely delete your merged branch by choosing X Delete branch in the bottom right.

Tips

ℹ️ If you see a Review warnings before merging warning, you can safely ignore it. This may appear when some outputs have not been built on the latest version of your code. ℹ️ In general, we recommend using Squash & Merge as this leaves a cleaner commit history on Master. However, choose a merge type that aligns with the preferences of your project administrator.

The foregoing exercises dealt with simple identity transforms at the start of your pipeline and therefore provided only a gloss over some many pull request features. We recommend pausing and reading the following documentation entries for more context.